Fixed ProgressBar#562
Merged
NiallJoeMaher merged 6 commits intocodu-code:developfrom Oct 19, 2023
Merged
Conversation
|
@seog-jun is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Do you have any ideas on why when I go to the homepage, it doesn't do the full animation? The other pages seem to be fine. 🤔 Screen.Recording.2023-10-19.at.08.32.32.mov |
Contributor
Author
|
@NiallJoeMaher Well, I don't really see that issue from my end, but I put the Codu.-.The.Web.Developer.Community.-.Google.Chrome.2023-10-19.06-31-43.online-video-cutter.com.mp4 |
NiallJoeMaher
requested changes
Oct 19, 2023
Contributor
NiallJoeMaher
left a comment
NiallJoeMaher
left a comment
There was a problem hiding this comment.
Could you remove the unused progress bar and package if we no longer are using it? Thanks! 🌮
Contributor
Author
|
@NiallJoeMaher For sure! |
Contributor
Author
|
@NiallJoeMaher Could you please review the PR again? I'd appreciate that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #551
✨ Codu Pull Request 💻
👉 Please remove the below and replace with your own values, leaving the headers where they are. 👈
Pull Request details:
NextTopLoadercomponent as the currentProgressBarcomponent is broke(Next.js 13doesn't supportrouter.events.on/offanymore)CSS gradientto apply the gradient toNextTopLoaderAny Breaking changes:
Associated Screenshots:
ProgressBar.mp4